Repository navigation
Fix Corrupting Cry Support area of effect penalty stacking additively - #10445
Open
lucaskarsten wants to merge 1 commit into
Open
lucaskarsten wants to merge 1 commit into
lucaskarsten wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Corrupting Cry Support's "Supported Skills have 20% less Area of Effect" (
support_corrupting_cry_area_of_effect_+%_final) has been mapped asINCsince the support was added (#6436), so it was added to the skill's increased area instead of multiplying it. The stat is a_finalstat and the in-game description reads "less", so it is now mapped asMORE, in bothsrc/Export/Skills/sup_str.txtand the generatedsrc/Data/Skills/sup_str.lua.Steps taken to verify a working solution:
TestOffence_spec.lua: Infernal Cry + Corrupting Cry with 40% increased Area of Effect now givesAreaOfEffectMod1.12; it fails ondevwith 1.20.TestRareLike_spec.lua:84, veiled unique affix pools) also fails ondevwithout this change.Link to a build that showcases this PR:
Any warcry supported by Corrupting Cry, plus any increased Area of Effect.
Before screenshot:
Infernal Cry 20 + Corrupting Cry 20, 40% increased Area of Effect: area of effect multiplier 1.20 (1 + 0.4 − 0.2).
After screenshot:
Same setup: 1.12 (1.4 × 0.8).