Skip to content

Fix Corrupting Cry Support area of effect penalty stacking additively #10445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucaskarsten wants to merge 1 commit into
base: dev
Choose a base branch
from
+11 −2
Open

Fix Corrupting Cry Support area of effect penalty stacking additively #10445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions spec/System/TestOffence_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,4 +428,13 @@ describe("TestOffence", function()
assert.are.equals(7, build.calcsTab.mainOutput.ActiveTotemLimit)
assert.are.equals(1.7, build.calcsTab.mainOutput.AreaOfEffectMod)
end)
it("applies Corrupting Cry's less area of effect multiplicatively", function()
build.skillsTab:PasteSocketGroup("Infernal Cry 20/0 1\nCorrupting Cry 20/0 1")
build.configTab.input.customMods = "40% increased Area of Effect"
build.configTab:BuildModList()
runCallback("OnFrame")

-- "Supported Skills have 20% less Area of Effect": (1 + 0.4) * 0.8, not 1 + 0.4 - 0.2
assertNearRelative(1.12, build.calcsTab.mainOutput.AreaOfEffectMod, 0.0001)
end)
end)
2 changes: 1 addition & 1 deletion src/Data/Skills/sup_str.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1448,7 +1448,7 @@ skills["SupportCorruptingCry"] = {
mod("CorruptingCryStagesFromExerted", nil, 0, KeywordFlag.Attack)
},
["support_corrupting_cry_area_of_effect_+%_final"] = {
mod("AreaOfEffect", "INC", nil, 0, KeywordFlag.Warcry)
mod("AreaOfEffect", "MORE", nil, 0, KeywordFlag.Warcry)
},
["support_corrupting_cry_warcry_and_first_exerted_attack_applies_corrupted_blood_for_X_ms"] = {
skill("durationSecondary", nil),
Expand Down
2 changes: 1 addition & 1 deletion src/Export/Skills/sup_str.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ return function(skills, mod, flag, skill)
mod("CorruptingCryStagesFromExerted", nil, 0, KeywordFlag.Attack)
},
["support_corrupting_cry_area_of_effect_+%_final"] = {
mod("AreaOfEffect", "INC", nil, 0, KeywordFlag.Warcry)
mod("AreaOfEffect", "MORE", nil, 0, KeywordFlag.Warcry)
},
["support_corrupting_cry_warcry_and_first_exerted_attack_applies_corrupted_blood_for_X_ms"] = {
skill("durationSecondary", nil),
Expand Down