Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 4, 2026
Contributor
posthog-python Compliance ReportDate: 2026-11-09T18:36:18.465216+00:00 ✅ All Tests Passed!270/270 tests passed Capture_V1 Tests✅ 95/95 tests passed View Details
Capture_Ai Tests✅ 5/5 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
Feature_Flags_V4 Tests✅ 149/149 tests passed View Details
Feature_Flags_Local_Evaluation Tests✅ 4/4 tests passed View Details
|
![posthog[bot]](https://avatars.githubusercontent.com/in/1203049?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PostHog Review · Standard · reviewed d811ca2: 6 Should fix, 1 Consider.
This is the only automatic review while this pull request is a draft. Comment @posthog review to review new changes sooner. Otherwise, a review of the new changes runs when you mark it ready for review.
See this review and its findings in PostHog Review. Comment @posthog review --deep for a Deep review. A Deep review takes longer and looks deeper than a Standard review.
Drops the Node renderer, its tests, the page check and the sdk-specs module. The generated pages are unchanged byte for byte. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nt matter Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 4, 2026
Replaces the 539-line renderer with griffe2md, a dev dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
SDK performance: posthog-pythonBenchmarks completed. No changes flagged for review. Flags require at least a 5% change in the median and all six pairs agreeing on direction. This is a noise filter, not proof of a performance change or a CI gate. View all results
Values are medians of paired measurements. Not flagged does not mean unchanged. Unavailable means a measurement could not be provided, not zero. Estimated allocation measurements retain their instrumentation uncertainty. RSS measures the whole process, not just SDK allocations; observed peaks are sampled checkpoints. Paired ranges in the diagnostics describe variability, not confidence intervals. Each shard uses its own runner; compare Before PR against With PR within a row, not across shards. Compared 102 metric rows; 102 rows shown in all results. Omitted or shortened data remain in |
gewenyu99
marked this pull request as ready for review
November 5, 2026 16:10
dustinbyrne
reviewed
Nov 5, 2026
dustinbyrne
left a comment
dustinbyrne
left a comment
Contributor
There was a problem hiding this comment.
I independently reproduced the existing annotation-leakage and coroutine-marker findings with the locked renderer. Consider correcting both and adding focused output tests before publishing the new reference. These are reference-output issues, not SDK runtime regressions. One optional schema-completeness suggestion is inline.
AI-assisted review.
griffe2md 1.5.1's signature template gives an unannotated parameter the previous parameter's annotation, so Client(...) showed `debug: str = False`. It also drops `async`. Swap its format_signature filter for griffe's own Function.signature(), prefixed with `async` for coroutines. Also document OptionalSetArgs and CodeEmailArgs in Types, since set, set_once and Emails.send reference them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The posthog-capability lines showed in IDE hover help. The docstrings read as they do on main again, Category sections included, and the generator drops those sections from the reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
turnipdabeets
approved these changes
Nov 5, 2026
Covers the two output bugs review reproduced: unannotated parameters getting the previous parameter's annotation, and coroutines missing async. Also checks the keyword-only marker. griffe and griffe2md join the test extra so CI runs them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Client(...) listed _use_ai_lane and _enable_multimodal_capture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s name - Summary tables keep a docstring's first paragraph, not its first line. - A Returns section is one return value, even when its description wraps. - A constructor's signature reads `Client(...)`, not `__init__(...)`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The context example tags with `tag`, since `tag_context` doesn't exist. - The `capture_exception` example passes `distinct_id` by keyword, since it's keyword-only. - Two reST `Example::` blocks become Markdown, which the reference renders. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Open
10 tasks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
johncwaters
approved these changes
Nov 9, 2026
johncwaters
left a comment
johncwaters
left a comment
There was a problem hiding this comment.
Note
Automated review by Glimmervoid, not written by a human. Approved by hand after checking it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
We have a wave of breaking changes with new major versions for most SDKs. References are now read mostly by bots, not humans, and the HogRef format is heavy. This generates the reference as Markdown from the doc comments.
bin/docs_scripts/generate_markdown.pyrenders each member with griffe2md, a newdevdependency, and groups them by capability. It writesreferences/posthog-python-<major>.md, andposthog-python-reference.mdfor the released major.docs/capabilities.jsonmaps each symbol to its sdk-specs capability, so the doc comments stay as they are. Generation fails on a stale entry, an unknown capability, or an unmapped client method.💚 How did you test it?
ruff, the mypy baseline andmake public_api_checkpass.pytest posthog/test: 6085 pass, and 3 fork tests fail only in the full run on macOS.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (Opus 5.5), directed by Vincent.
Merge order
/docs/libraries/python/referenceis livedatafield) and the SDK repos (their JSON files)🤖 Generated with Claude Code