[EmandM]

Purpose of this PR

Ensure required NetworkManager methods are protected virtual so the base versions can be called when overridden.

Jira ticket

UUM-159597

Changelog

• Fixed: Resolves exceptions being thrown when a derived NetworkManager implements their own Awake.

Documentation

• No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

• Manual testing done

Automated tests:

• Covered by existing automated tests
• Covered by new automated tests

Does the change require QA team to:

• Review automated tests?
• Execute manual tests?
• Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

Up-ported by #4244

Backports

n/a

[u-pr]

💡 Harness Review

The logger fallbacks consistently cover all three startup modes, and the lifecycle methods now allow derived managers to invoke their base implementations.

_{Reviewed commit e6693e9}

_{🤖 Helpful? 👍/👎}

[NoelStephensUnity]

LGTM!

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...netcode.gameobjects/Runtime/Core/NetworkManager.cs	62.96%	10 Missing ⚠️

@@                Coverage Diff                @@
##           develop-2.0.0    #4237      +/-   ##
=================================================
+ Coverage          74.36%   74.77%   +0.40%     
=================================================
  Files                172      172              
  Lines              28291    28400     +109     
=================================================
+ Hits               21039    21236     +197     
+ Misses              7252     7164      -88     

Flag	Coverage Δ
NGOv2_project_testproject_ubuntu	74.42% <62.96%> (+0.38%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...netcode.gameobjects/Runtime/Core/NetworkManager.cs	79.23% <62.96%> (-0.39%)	⬇️

... and 3 files with indirect coverage changes

Components	Coverage Δ
com.unity.netcode.gameobjects	74.77% <86.36%> (+0.40%)	⬆️

ℹ️ Need help interpreting these results?