Repository navigation
Conversation
1 of 6 tasks
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change makes the lifecycle hooks overridable and adds logger fallbacks, but the teardown refactor introduces a syntax error that prevents the package from compiling.
Reviewed commit bcb9486
🤖 Helpful? 👍/👎
| // Note that this gets also called manually by OnSceneUnloaded and OnApplicationQuit | ||
| private void OnDestroy() | ||
| private void DestroyInternal() | ||
| { |
Contributor
There was a problem hiding this comment.
The runtime assembly cannot compile because DestroyInternal now has two opening braces but only one closing brace. The original opening brace remains immediately after the newly added brace. Consequently, subsequent member declarations appear inside DestroyInternal, and the file ends with an unmatched brace. Remove the extra opening brace.
🤖 Helpful? 👍/👎
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ensure required NetworkManager methods are protected virtual so the base versions can be called when overridden.
Up-port of #4237
Jira ticket
UUM-159597
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Up-port
n/a
Backports
Backported by #4237