Repository navigation
use ConfigKeys for alert, storage, guest network and hidden settings - #14473
Open
DaanHoogland wants to merge 4 commits into
Open
DaanHoogland wants to merge 4 commits into
DaanHoogland wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ghi10752-config-foundation #14473 +/- ##
===============================================================
Coverage 20.80% 20.80%
Complexity 20846 20846
===============================================================
Files 6069 6069
Lines 548527 548488 -39
Branches 73236 78659 +5423
===============================================================
+ Hits 114119 114120 +1
+ Misses 421065 421033 -32
+ Partials 13343 13335 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.73% |
| Branch coverage | 20.84% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
DaanHoogland
force-pushed
the
ghi10752-config-core-1
branch
from
October 23, 2026 14:58
69d0a74 to
217fb98
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
DaanHoogland
force-pushed
the
ghi10752-config-core-1
branch
from
October 27, 2026 17:08
217fb98 to
ee7248d
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
DaanHoogland
force-pushed
the
ghi10752-config-core-1
branch
from
October 28, 2026 07:51
ee7248d to
3664fd4
Compare
JoaoJandre
reviewed
Oct 29, 2026
JoaoJandre
approved these changes
Nov 6, 2026
JoaoJandre
left a comment
JoaoJandre
left a comment
Contributor
There was a problem hiding this comment.
CLGTM, did not test it
Part of the split of #13884 (phase out the Config enum, #10752). Co-Authored-By: Claude Opus 5.5 <[email protected]>
The usage server has no ConfigDepot, so ConfigKey.value() only returns the built-in defaults there. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
DaanHoogland
force-pushed
the
ghi10752-config-core-1
branch
from
November 13, 2026 16:14
3664fd4 to
ab4c4c8
Compare
3 of 14 tasks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches the alert, storage, guest network and hidden-setting call sites to
ConfigKeys.Split out of #13884 (phase out the deprecated
Configenum, #10752). Depends on #14467. Independent of the other PRs that depend on #14467, so it can be reviewed and merged in any order relative to them; GitHub retargets it tomainonce #14467 is merged.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Local verification: full reactor build (checkstyle included) and the unit tests of every touched module pass on this branch; merging all PRs of the split in any order gives no conflicts and reproduces #13884 plus its fixes.
🤖 Generated with Claude Code