Repository navigation
Conversation
Deploying mouseterm with
|
| Latest commit: |
09962cc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0385c73a.mouseterm.pages.dev |
| Branch Preview URL: | https://dor-v2-07-placement.mouseterm.pages.dev |
dormouse-bot
left a comment
Collaborator
There was a problem hiding this comment.
One finding, inline: the early --from placement check also runs on requests that reuse an existing browser, so a reference that later becomes unavailable breaks a browser that needs no placement.
nedtwigg
force-pushed
the
dor-v2-07-placement
branch
from
November 12, 2026 03:31
1f590c2 to
d566214
Compare
nedtwigg
force-pushed
the
dor-v2-06-completion
branch
from
November 12, 2026 05:10
821c120 to
5ca75a5
Compare
nedtwigg
force-pushed
the
dor-v2-07-placement
branch
from
November 12, 2026 05:10
d566214 to
289f592
Compare
nedtwigg
marked this pull request as ready for review
November 12, 2026 07:06
split, ensure, tool, open, and iframe take their placement reference as --from instead of --surface; --surface now only names the existing browser dor agent-browser and dor playwright drive. Browser providers intercept --from anywhere before an optional bare --, reject it beside --surface before the provider runs, and carry it to resolveBrowser and surface.browser, where it routes the request and scopes a --key to its Workspace. Browser --from fails only a placement the request would make: resolveBrowser checks it before the provider runs when a binding command finds no Surface for its key, and surface.browser before attaching when no Surface shows the key or session. A stale, minimized, or other-Workspace reference no longer fails a reuse, a holder Workspace's answer, or a diagnostics or viewport request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nedtwigg
force-pushed
the
dor-v2-06-completion
branch
from
November 12, 2026 07:31
5ca75a5 to
c588eb5
Compare
nedtwigg
force-pushed
the
dor-v2-07-placement
branch
from
November 12, 2026 07:31
289f592 to
8bbfa0d
Compare
dormouse-bot
approved these changes
Nov 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface-creating commands now take their placement reference as
--from:split,ensure,tool,open, andiframe. The old placement spelling--surfaceis rejected.--surfacenow only names the existing browser thatdor agent-browseranddor playwrightdrive.The browser providers read
--fromlike their other Dormouse options: anywhere in the argv, up to an optional bare--that ends interception. They reject it together with--surfacebefore invoking the provider, and carry it tosurface.resolveBrowserandsurface.browser. The shared router routes on the placement reference, so a--keyresolves in that Surface's Workspace. Private non-browser control requests keep their existingsurfacereference field.Browser
--fromfails only a placement the request would make:surface.resolveBrowserchecks it before the provider runs, when a command that may bind finds no Surface for its key.surface.browserchecks it before attaching, when no Surface in the answering Wall shows the key or session.A stale, minimized, or other-Workspace reference therefore never fails a reuse, the Workspace that holds the session answering it, or a diagnostics or
dor-embed-sizerequest. Example:--from surface:selfafter the user minimized the agent's terminal.Help, the skill, takeover wording, and specs use the new syntax. The skill describes
--fromonce, under "Browser identity": it places only a pane the command creates. It does not tell agents to repeat it, except to keep a key they placed in another Workspace.docs/specs/layout.md's split-from-a-Door rule now defers to "Focus intent", since a split that takes focus is laid out as a pane. Root split help has a regression check for grouped directions and its--boundary.Stack: 7/8, based on #1743. Breaking change for Dormouse 2.0.
Validation:
tsc -b; the Wall,wall/(router, use-dor-control, tool-takeover, preview-slot, and the rest), and WorkspaceWindow suites, 71 files and 1508 testspnpm test(typecheck plus 486 tests); standalonetsc --noEmitlint:specs(dor-cli budget ratcheted to 6200) and its 58 self-checks,lint:md,lint:public-docs,git diff --checkMutation checks:
--fromrequest fails the reuse, resolution, and cross-Workspace holder testssurface.browserreuse, or not at all, fails the reuse or the refusal-before-attach testresolveBrowsercreate-only check fails the resolution test, as does checking diagnostics or the viewport--from/--surfaceexclusion in the CLI fails the browser placement test