Repository navigation
docs(vue): import ionicons after @ionic/vue in the Your First App snippets - #4842
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
approved these changes
Nov 12, 2026
thetaPC
left a comment
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
LGTM
The changes will also need to be done in docs.
Member
Author
|
@thetaPC This is the docs 😬 But the tutorial PR is linked. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Updates the Vue "Your First App" snippets to match the tutorial app's import order: ionic-team/tutorial-photo-gallery-vue#70
Changes
Tab2Page.vuesnippets inyour-first-app.mdx,2-taking-photos.mdx, and7-live-reload.mdximportionicons/iconsafter@ionic/vue, the order Ionic's lint rules require now that they apply to.vuefiles in the tutorial app.Notes
ionic startcreates.