Skip to content

docs(vue): import ionicons after @ionic/vue in the Your First App snippets #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandyscarney merged 1 commit into from
Nov 12, 2026
Merged

docs(vue): import ionicons after @ionic/vue in the Your First App snippets #4842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/vue/your-first-app.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,10 @@ We put the visual aspects of our app into `<ion-content>`. In this case, it’s
</template>

<script setup lang="ts">
// CHANGE: Add import from `ionicons/icons`
import { camera } from 'ionicons/icons';
// CHANGE: Update import from `@ionic/vue` to include necessary Ionic components
import { IonPage, IonHeader, IonFab, IonFabButton, IonIcon, IonToolbar, IonTitle, IonContent } from '@ionic/vue';
// CHANGE: Add import from `ionicons/icons`
import { camera } from 'ionicons/icons';
// CHANGE: Remove or comment out the ExploreContainer import
// import ExploreContainer from '@/components/ExploreContainer.vue';
</script>
Expand Down
4 changes: 2 additions & 2 deletions docs/vue/your-first-app/2-taking-photos.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ Next, in `Tab2Page.vue`, import the `usePhotoGallery()` method and destructure i
</template>

<script setup lang="ts">
import { camera } from 'ionicons/icons';
import { IonPage, IonHeader, IonFab, IonFabButton, IonIcon, IonToolbar, IonTitle, IonContent } from '@ionic/vue';
import { camera } from 'ionicons/icons';

// CHANGE: Add `usePhotoGallery` import
import { usePhotoGallery } from '@/composables/usePhotoGallery';
Expand Down Expand Up @@ -245,7 +245,6 @@ Next, switch to `Tab2Page.vue` to display the images. We'll add a [Grid componen
</template>

<script setup lang="ts">
import { camera } from 'ionicons/icons';
import {
IonPage,
IonHeader,
Expand All @@ -259,6 +258,7 @@ import {
IonRow,
IonCol,
} from '@ionic/vue';
import { camera } from 'ionicons/icons';

import { usePhotoGallery } from '@/composables/usePhotoGallery';

Expand Down
4 changes: 2 additions & 2 deletions docs/vue/your-first-app/7-live-reload.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ Next, in `Tab2Page.vue`, implement the `showActionSheet()` method. We're adding

<script setup lang="ts">
// CHANGE: Update import
import { camera, trash, close } from 'ionicons/icons';
// CHANGE: Update import
import {
IonPage,
IonHeader,
Expand All @@ -108,6 +106,8 @@ import {
IonCol,
actionSheetController,
} from '@ionic/vue';
// CHANGE: Update import
import { camera, trash, close } from 'ionicons/icons';

// CHANGE: Add `UserPhoto` type import
import type { UserPhoto } from '@/composables/usePhotoGallery';
Expand Down
Loading