Repository navigation
Conversation
moetemp
force-pushed
the
moe/brook/review/s1-stream-protos
branch
3 times, most recently
from
October 28, 2026 01:33
92725de to
7afb312
Compare
moetemp
changed the base branch from
moe/brook/review/g1-common-package
to
moe/brook/review/base
November 5, 2026 17:18
moetemp
force-pushed
the
moe/brook/review/s1-stream-protos
branch
from
November 5, 2026 17:19
3499fa7 to
8767e51
Compare
moetemp
changed the base branch from
moe/brook/review/base
to
moe/brook/review/b1-streams-feature
November 5, 2026 23:10
moetemp
force-pushed
the
moe/brook/review/s1-stream-protos
branch
from
November 5, 2026 23:10
8767e51 to
67d9bbf
Compare
moetemp
force-pushed
the
moe/brook/review/b1-streams-feature
branch
from
November 5, 2026 23:10
4348531 to
1a66759
Compare
moetemp
changed the title
Owner
Author
|
Closed in favor of #381, the combined branch, which has this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR vendors the Redis Store's config proto and adds its generated code in
temporalio/streams/proto/.redis.protois the config of the Redis runtime intemporal-community/sdk-streamsatdc93cba6. It isn't a Core proto, soscripts/gen_protos.pygenerates it intotemporalio/streams/proto/, which the API docs keep private. The memory runtime's config,coresdk.streams.MemoryStreamConfigin Core, has the same field numbers.temporalio.streams. #373 checks the copy against the Redis crate that the bridge links.Why?
The Redis backend of #376 builds this config. The Stream service protos and the runtime's own messages come from the Core submodule in #370.
Part of the Streams review series.
Checklist
scripts/gen_protos.pyon the protobuf 3 toolchain leaves no diff, andpoe lintandpoe gen-docspass.