Skip to content

[Brook S2] Generated the Stream service bindings with nexgen, and added the writer client. - #372

Closed
moetemp wants to merge 1 commit into
moe/brook/review/s1-stream-protosfrom
moe/brook/review/s2-stream-bindings
Closed

moetemp wants to merge 1 commit into
moe/brook/review/s1-stream-protosfrom
moe/brook/review/s2-stream-bindings

Conversation

@moetemp

@moetemp moetemp commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

This PR vendors the Stream service WIT and generates its Python bindings with nexgen, into temporalio/streams/system/. It also adds the writer client in temporalio/streams/writer_system/, written by hand.

Why?

The Streams API calls the Stream service through generated bindings, as the SDK calls the Workflow Service System Nexus operations. They're generated, so they get their own PR, before the hand-written Stream code. The writer client is here too, since it has the same shape.

Part of the Streams review series.

Checklist

  1. How was this tested:
    • A regeneration with scripts/gen_stream_service.py and the pinned nexgen leaves no diff. poe lint, poe gen-docs and the binding tests pass.

@moetemp moetemp added the skip-changelog Changelog entry rides another PR label Oct 25, 2026
@moetemp
moetemp force-pushed the moe/brook/review/s2-stream-bindings branch 3 times, most recently from 3925df2 to f2a5ec4 Compare October 26, 2026 08:44
@moetemp
moetemp force-pushed the moe/brook/review/s1-stream-protos branch from 235fde0 to 3b5246f Compare October 26, 2026 08:44
@moetemp
moetemp force-pushed the moe/brook/review/s2-stream-bindings branch from f2a5ec4 to ba649e0 Compare October 27, 2026 09:07
@moetemp
moetemp force-pushed the moe/brook/review/s1-stream-protos branch from 3b5246f to 92725de Compare October 27, 2026 09:07
@moetemp
moetemp force-pushed the moe/brook/review/s2-stream-bindings branch from ba649e0 to e1864c4 Compare October 27, 2026 09:17
@moetemp
moetemp force-pushed the moe/brook/review/s1-stream-protos branch from 92725de to 7afb312 Compare October 28, 2026 01:33
@moetemp
moetemp force-pushed the moe/brook/review/s2-stream-bindings branch from e1864c4 to 50537f7 Compare October 28, 2026 01:33
@moetemp moetemp changed the title [Brook S2] Generated the Stream service and writer bindings with nexgen. [Brook S2] Generated the Stream service bindings with nexgen, and added the writer client. Nov 1, 2026
@moetemp
moetemp force-pushed the moe/brook/review/s1-stream-protos branch from 3499fa7 to 8767e51 Compare November 5, 2026 17:19
@moetemp
moetemp force-pushed the moe/brook/review/s2-stream-bindings branch from 499bbee to 36fef14 Compare November 5, 2026 17:19
@moetemp
moetemp force-pushed the moe/brook/review/s2-stream-bindings branch from 36fef14 to 7647af5 Compare November 5, 2026 23:10
@moetemp
moetemp force-pushed the moe/brook/review/s1-stream-protos branch from 8767e51 to 67d9bbf Compare November 5, 2026 23:10
@moetemp
moetemp force-pushed the moe/brook/review/s2-stream-bindings branch from 7647af5 to d535338 Compare November 6, 2026 09:06
The WIT copy keeps the TypeScript and .NET poll as a TODO comment, as
nexgen's sample does, until nexgen supports them.
@moetemp
moetemp force-pushed the moe/brook/review/s2-stream-bindings branch from d535338 to 9885bad Compare November 6, 2026 09:22
@moetemp

moetemp commented Nov 10, 2026

Copy link
Copy Markdown
Owner Author

Closed in favor of #381, the combined branch, which has this change.

@moetemp moetemp closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Changelog entry rides another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant