Repository navigation
fix(lint): check the treatment agent's Close; nixfmt quality.nix - #306
Merged
Merged
Conversation
#305 added the treatment tag to the golangci tiers, which linted cmd/xtcp2/treatments_embedded.go for the first time (errcheck on a.Close), and its quality.nix edit was not nixfmt-clean. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has been red on lint since #305.
treatmenttag to the golangci tiers, so they lintedcmd/xtcp2/treatments_embedded.gofor the first time. errcheck flagged the uncheckeda.Close(); the error is now logged.nix/tests/tcp-controller/quality.nixis nixfmt-formatted.🤖 Generated with Claude Code