Skip to content

fix(lint): check the treatment agent's Close; nixfmt quality.nix #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randomizedcoder merged 1 commit into from
Nov 14, 2026
Merged

fix(lint): check the treatment agent's Close; nixfmt quality.nix #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmd/xtcp2/treatments_embedded.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,11 @@ func startEmbeddedTreatmentAgent(ctx context.Context, path, location string) (*t
var wg sync.WaitGroup
wg.Add(1)
go func() { defer wg.Done(); a.Run(ctx) }()
return &treatmentFeeder{stamp: a.Stamp, wake: a.Wake}, func() { wg.Wait(); a.Close() }, nil
stop := func() {
wg.Wait()
if err := a.Close(); err != nil {
log.Printf("treatment agent: close: %v", err)
}
}
return &treatmentFeeder{stamp: a.Stamp, wake: a.Wake}, stop, nil
}
4 changes: 3 additions & 1 deletion nix/tests/tcp-controller/quality.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ let
# These fixtures must execute, never silently skip in the focused checks.
grep -q -- '--- PASS: TestPostgresConcurrentReviewFencesReplicas' "$out/tests.log"
grep -q -- '--- PASS: TestClickHouseAnalysisCounterDeltas' "$out/tests.log"
go test -tags treatment -ldflags=-checklinkname=0 ${if race then "-race -count=3" else "-count=1 -cover"} \
go test -tags treatment -ldflags=-checklinkname=0 ${
if race then "-race -count=3" else "-count=1 -cover"
} \
-timeout 5m -v -run '^TestTreatment' ./internal/goip/actuate > "$out/routes.log" 2>&1 \
|| { cat "$out/routes.log"; exit 1; }
${if race then "" else coverageTable}
Expand Down
Loading