Repository navigation
test: mitigate config watcher startup races - #620
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
0edd779
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2976d7df.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-test-watch-startu.rstack-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Build completion can be reported before the config restart watcher finishes its initial scan. Immediately editing a config can therefore miss the change event and leave watch tests waiting for a restart.
Changes
Wait 100ms before edits in the doc and lib config-reload tests, including after restarts. This mitigates the race without exposing watcher internals; it does not guarantee readiness on every machine.
The six tests passed five consecutive local macOS runs with each of
forksandvmForks. The delay is reduced from the 200ms workaround originally included in #617, which this PR separates from the pool migration.