Repository navigation
chore(test): use vmForks for Rstack tests - #617
Open
chenjiahan wants to merge 6 commits into
Open
chenjiahan wants to merge 6 commits into
chenjiahan wants to merge 6 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
688a3a1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5239616e.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-test-vm-forks.rstack-cli.pages.dev |
chenjiahan
changed the base branch from
main
to
chenjiahan/test-watch-startup-delay
November 6, 2026 13:29
chenjiahan
changed the base branch from
main
to
chenjiahan/fix-hooks-cross-realm-errors
November 6, 2026 14:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Reduce test worker startup overhead by using
vmForksfor the Rstack package.Changes
Enable
vmForksand run three native-loader scenarios in Node subprocesses.Depends on #621 for cross-realm filesystem error handling; this PR targets that branch to keep the diff focused on the pool migration. Config-watch test stabilization was merged separately in #620.
CI timings below are mean test command wall times from six alternating runs per pool on the same runner, after one warmup. All 42 executions passed with matching test counts between pools. These measurements used the earlier 200ms watch-test delay in both pools.
forksvmForks