Repository navigation
fix(hooks): recognize cross-realm filesystem errors - #621
Open
chenjiahan wants to merge 1 commit into
Open
chenjiahan wants to merge 1 commit into
chenjiahan wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
151e74a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6517117d.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-fix-hooks-cross-r.rstack-cli.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Filesystem errors from another VM realm fail
instanceof Error, causing hook installation to misclassifyEEXISTowner-file conflicts as write failures and stringify errors instead of using their messages. This surfaced during the VM pool migration in #617.Changes
Use
util.types.isNativeErrorfor both checks, retaining compatibility with supported Node versions. Add two cross-realm regression tests that fail before the fix and pass afterward; the hooks suite passes under bothforksandvmForks.