Repository navigation
Pin the Arize sample to temporalio 1.36.0 - #420
Merged
Merged
Conversation
The reset case depends on 1.36.0 applying a Workflow Task's jobs as a single batch, so a reapplied update's span gets a fresh ID instead of reusing the original run's. temporalio/sdk-python#2121 turns that off by default again for 1.36.1 while the cancellation semantics are settled in temporalio/sdk-python#2124, so the next release would bring the duplicate IDs back. The pyproject comment and the README say why the pin exists and when to lift it.
VegetarianOrc
approved these changes
Nov 14, 2026
Comment on lines
+8
to
+9
| # run. 1.36.1 (temporarily?) undoes that, so we're pinning to 1.36.0 | ||
| # explicitly until a future release resolves this issue one way or another. |
Contributor
There was a problem hiding this comment.
Suggested change
| # run. 1.36.1 (temporarily?) undoes that, so we're pinning to 1.36.0 | |
| # explicitly until a future release resolves this issue one way or another. | |
| # run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins the Arize sample to
temporalio==1.36.0.The sample's reset case depends on 1.36.0 applying a Workflow Task's jobs as a single batch, so a reapplied Update's span gets a fresh ID instead of reusing the original run's. temporalio/sdk-python#2121 turns that off by default again for 1.36.1 while the cancellation semantics are settled in temporalio/sdk-python#2124, so the next release would bring the duplicate span IDs back. The pyproject comment and the README's reset note say why the pin exists and when to lift it. The lock resolution is unchanged; the sample's tests, ruff, and mypy pass.