Skip to content

Pin the Arize sample to temporalio 1.36.0 #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DABH merged 3 commits into from
Nov 14, 2026
Merged

Pin the Arize sample to temporalio 1.36.0 #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d05283
Pin the Arize sample to temporalio 1.36.0
DABH Nov 14, 2026
98621dd
clean up comments
DABH Nov 14, 2026
3ecf681
clean up comments
DABH Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions arize_tracing/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,7 @@ temporal workflow reset --workflow-id <workflow id> --type FirstWorkflowTask --r
uv run verify_trace.py --workflow-id <workflow id> --expect-runs 2
```

The reset case needs temporalio 1.36.0 or later. Earlier releases ran the
reapplied update before reseeding the new run, so its `HandleUpdate` span
reused the original `RunWorkflow` span's ID
([temporalio/sdk-python#2081](https://github.com/temporalio/sdk-python/pull/2081)).
The reset case currently needs temporalio 1.36.0 exactly (see PR #420).

![Activity retry attempts in Phoenix](phoenix-retry-attempts.png)

Expand Down
8 changes: 5 additions & 3 deletions arize_tracing/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ name = "temporalio-samples-arize-tracing"
version = "0.1.0"
requires-python = ">=3.11"
dependencies = [
# 1.36.0 applies workflow activation jobs as a single batch, which keeps a
# reset's reapplied update from reusing a span ID of the original run.
"temporalio[opentelemetry]>=1.36.0,<2",
# Pinned: 1.36.0 applies workflow activation jobs as a single batch, which
# keeps a reset's reapplied update from reusing a span ID of the original
# run. 1.36.1 (temporarily?) undoes that, so we're pinning to 1.36.0
# explicitly until a future release resolves this issue one way or another.
Comment on lines +8 to +9

@VegetarianOrc VegetarianOrc Nov 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# run. 1.36.1 (temporarily?) undoes that, so we're pinning to 1.36.0
# explicitly until a future release resolves this issue one way or another.
# run.

"temporalio[opentelemetry]==1.36.0",
# 1.1.0 fixes span parenting when one worker runs both workflows and
# activities; its openinference extra brings the Agents SDK instrumentation.
"temporalio-openai-agents[openinference]>=1.1.0",
Expand Down
4 changes: 2 additions & 2 deletions arize_tracing/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading